Skip satisfied dependencies during installation #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Apr 29, 2020
uranusjr
reviewed
Apr 29, 2020
- Skip satisfied dependencies in the environment during install by checking whether the constraint of a specifier is satisfied - If there is no specifier and a dependency is installed, assume it is satisfied - For editable dependencies, if the dependency in the environment is an egg link and points at the same path as the given dep, assume it is satisfied - Fixes #3057 Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
techalchemy
force-pushed
the
feature/only-install-missing
branch
from
ca53d85
to
69d785d
Compare
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
|
Ooh, I have some janky CI chicanery to try removing now :) Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by checking whether the constraint of a specifier is satisfied
is satisfied
an egg link and points at the same path as the given dep, assume
it is satisfied